[move-vm] Types and opcodes for closures #15171
Draft
+710
−6,878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR implements the extensions needed in the file format for representing closures: - The type (SignatureToken) has a new variant `Function(args, result, abilities)` to represent a function type - The opcodes are extendeed by operations `ClosPack`, `ClosPackGeneric`, and `ClosEval` This supports bit masks for specifyinng which arguments of a function are captured when creating a closure. Bytecode verification is extended to support the new types and opcodes. The implementation of consistency, type, and reference safety should be complete. What is missing are: - File format serialization - Interpreter and value representation - Value serialization - Connection of the new types with the various other type representations
⏱️ 13m total CI duration on this PR
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
wrwg
requested review from
brmataptos,
georgemitenkov,
runtian-zhou,
vgao1996 and
ziaptos
|
@wrwg it is probably better to factor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the extensions needed in the file format for representing closures:
Function(args, result, abilities)to represent a function typeClosPack,ClosPackGeneric, andClosEvalThis supports bit masks for specifyinng which arguments of a function are captured when creating a closure.
Bytecode verification is extended to support the new types and opcodes. The implementation of consistency, type, and reference safety should be complete. What is missing are:
This also removes the obsolete crate
testing-infra/test-generation. This crate already did not support many older bytecode extensions, e.g. vector ops, and is nowhere used.How Has This Been Tested?
No tests yet
Type of Change
Which Components or Systems Does This Change Impact?